LGTM.
If splice is carving a big chunk out of an array it would make sense to
reuse
the backing store for the returned array instead of for the receiver.
That's
just an idea for another change, not for this one.
http://codereview.chromium.org/1562001/diff/1/2
File src/builtins.cc (right):
http://codereview.chromium.org/1562001/diff/1/2#newcode352
src/builtins.cc:352: MemsetPointer(former_start, filler_map, to_trim);
It would be faster to put a byte array here in the case where the size
is more than a few words. Then you only have to tough the start.
http://codereview.chromium.org/1562001
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
