http://codereview.chromium.org/1562001/diff/1/2 File src/builtins.cc (right):
http://codereview.chromium.org/1562001/diff/1/2#newcode352 src/builtins.cc:352: MemsetPointer(former_start, filler_map, to_trim); Anyway, I think that for now I'd better put it---it'd be easier to remove later. On 2010/03/30 12:15:50, antonm wrote:
On 2010/03/30 12:05:42, Erik Corry wrote: > It would be faster to put a byte array here in the case where the
size is more
> than a few words. Then you only have to tough the start.
That's true, but I have another idea: when I need to grow an array at
the start
(for unshift and some forms of splice like splice(0, 0, ...), I can
check if
words before a single word fillers and reuse them.
That might be problematic if we ever store those maps in the objects
(btw, do
you know if we do), so I'd like to see performance impact first. And
if it's
not worth it, then, yes, I'd switch to variable size fillers here.
http://codereview.chromium.org/1562001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
