LGTM
http://codereview.chromium.org/1533004/diff/1/5 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1533004/diff/1/5#newcode6233 src/ia32/codegen-ia32.cc:6233: Result result = allocator_->Allocate(); shouldn't you Unuse fp and result at the end of the function? it looks like a common convention. http://codereview.chromium.org/1533004/diff/1/5#newcode6233 src/ia32/codegen-ia32.cc:6233: Result result = allocator_->Allocate(); just curious: any chances allocating the single reg would be faster even given that control flow would become more involved? http://codereview.chromium.org/1533004/diff/1/5#newcode6254 src/ia32/codegen-ia32.cc:6254: if (FLAG_debug_code) __ AbortIfNotSmi(result.reg()); two questions. 1) why not use cmov still? 2) do we know what happens more often? there is a redundant load to result.reg(), of course, that's immediate so it hardly matters, just curious. http://codereview.chromium.org/1533004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
