LGTM.
I think this is a border-line case for cmov. I'm fine not using cmov here:
It
probably doesn't make a big difference. cmov is a little more compact, but
since
we don't inline this in a lot of places (only our built-ins) the code-size
reduction is not big either.
http://codereview.chromium.org/1533004/diff/1/5
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1533004/diff/1/5#newcode6233
src/ia32/codegen-ia32.cc:6233: Result result = allocator_->Allocate();
On 2010/03/30 13:28:05, antonm wrote:
shouldn't you Unuse fp and result at the end of the function? it
looks like a
common convention.
Unuse() is called by the destructor of Result at the end. In this case
since we don't allocate other things before that there is no need to
explicitly call Unuse.
http://codereview.chromium.org/1533004
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
