LGTM with comments.
http://codereview.chromium.org/1529004/diff/8001/9001 File src/conversions.cc (right): http://codereview.chromium.org/1529004/diff/8001/9001#newcode246 src/conversions.cc:246: static double InternalStringToInt(Iterator current, indentation seems unnecessary. http://codereview.chromium.org/1529004/diff/8001/9001#newcode276 src/conversions.cc:276: if (current == end) return SignedZero(sign); 0x and 0X should evaluate to 0 or NaN depending on who called StringToInt. "0x " - 3 => -3 parseInt("0x ") => NaN http://codereview.chromium.org/1529004/diff/8001/9001#newcode290 src/conversions.cc:290: if (current == end) return SignedZero(sign); same here. http://codereview.chromium.org/1529004/diff/8001/9001#newcode312 src/conversions.cc:312: if ((radix & (radix - 1)) == 0) { use IsPowerOf2 (see utils.h) http://codereview.chromium.org/1529004/diff/8001/9001#newcode340 src/conversions.cc:340: const int kBufferSize = kMaxSignificantDigits + 2; Explain why +2. http://codereview.chromium.org/1529004/diff/8001/9002 File src/runtime.cc (right): http://codereview.chromium.org/1529004/diff/8001/9002#newcode4683 src/runtime.cc:4683: return Heap::NumberFromDouble(value); leave RUNTIME_ASSERT(radix == 0 || 2<= radix && radix <= 36); http://codereview.chromium.org/1529004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
