http://codereview.chromium.org/1529004/diff/8001/9001
File src/conversions.cc (right):
http://codereview.chromium.org/1529004/diff/8001/9001#newcode246
src/conversions.cc:246: static double InternalStringToInt(Iterator
current,
On 2010/03/30 15:08:44, Florian Loitsch wrote:
indentation seems unnecessary.
Done.
http://codereview.chromium.org/1529004/diff/8001/9001#newcode276
src/conversions.cc:276: if (current == end) return SignedZero(sign);
On 2010/03/30 15:08:44, Florian Loitsch wrote:
0x and 0X should evaluate to 0 or NaN depending on who called
StringToInt.
"0x " - 3 => -3
parseInt("0x ") => NaN
Fixed. Test added.
http://codereview.chromium.org/1529004/diff/8001/9001#newcode290
src/conversions.cc:290: if (current == end) return SignedZero(sign);
On 2010/03/30 15:08:44, Florian Loitsch wrote:
same here.
Fixed. Test added.
http://codereview.chromium.org/1529004/diff/8001/9001#newcode312
src/conversions.cc:312: if ((radix & (radix - 1)) == 0) {
On 2010/03/30 15:08:44, Florian Loitsch wrote:
use IsPowerOf2 (see utils.h)
Done.
http://codereview.chromium.org/1529004/diff/8001/9001#newcode340
src/conversions.cc:340: const int kBufferSize = kMaxSignificantDigits +
2;
On 2010/03/30 15:08:44, Florian Loitsch wrote:
Explain why +2.
Done.
http://codereview.chromium.org/1529004/diff/8001/9002
File src/runtime.cc (right):
http://codereview.chromium.org/1529004/diff/8001/9002#newcode4683
src/runtime.cc:4683: return Heap::NumberFromDouble(value);
On 2010/03/30 15:08:44, Florian Loitsch wrote:
leave RUNTIME_ASSERT(radix == 0 || 2<= radix && radix <= 36);
Done.
http://codereview.chromium.org/1529004
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
