LGTM
Thanks for the patch, I will land it when the minor comments have been
addressed
and the patch synced with bleedng_edge HEAD.
http://codereview.chromium.org/1320006/diff/1/9
File src/mips/assembler-mips.h (right):
http://codereview.chromium.org/1320006/diff/1/9#newcode474
src/mips/assembler-mips.h:474: void mfc1(Register rt, FPURegister fs);
Will mthc1 and mfhc1 be implemented again - or are they not needed?
http://codereview.chromium.org/1320006/diff/1/4
File src/mips/codegen-mips.cc (right):
http://codereview.chromium.org/1320006/diff/1/4#newcode1184
src/mips/codegen-mips.cc:1184: __ bind(&retry); // pass last failure
(v0) as parameter (a0) when retrying
Uppercase initial letter in comment and end with period.
http://codereview.chromium.org/1320006/diff/1/3
File test/cctest/test-mips.cc (right):
http://codereview.chromium.org/1320006/diff/1/3#newcode47
test/cctest/test-mips.cc:47:
Why not leave the function without any arguments in the test as well (I
mean have both the previous and the new test)?
http://codereview.chromium.org/1320006
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
