On 2010/04/08 09:55:13, Alexandre wrote:
Hi,
I just updated test-mips.cc with a cleaner test.
Thanks,
Alexandre
http://codereview.chromium.org/1320006/diff/15001/16002
File test/cctest/test-mips.cc (right):
http://codereview.chromium.org/1320006/diff/15001/16002#newcode58
test/cctest/test-mips.cc:58: CHECK_EQ(0x80, script->Run()->Int32Value());
On 2010/04/08 09:33:12, Søren Gjesse wrote:
> I was actually thinking of testing both functions, maybe like this:
>
> const char* c_source_1 = "function foo() { return 0x1234; }; foo();";
> Local<String> source_1 = ::v8::String::New(c_source_1);
> Local<Script> script_1 = ::v8::Script::Compile(source_1);
> CHECK_EQ(0x1234, script_1->Run()->Int32Value());
>
> And then the other one c_source_2, source_2, script_2 - or make two
scopes.
Changed.
Thanks, the patch is ready for commit, but the MIPS port needs to be
updated to
build on current trunk. Feel free to do that in this patch if you like, or
create a separate one for that.
http://codereview.chromium.org/1320006/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
