I looked mainly at the code generator changes, which LGTM. Maybe Lasse
should
take a closer look at the runtime changes.
http://codereview.chromium.org/1563005/diff/2001/3005
File src/heap.h (right):
http://codereview.chromium.org/1563005/diff/2001/3005#newcode896
src/heap.h:896: // Allocate unitialized fixed array.
There's a typo in this comment: unitialized ==> uninitialized.
http://codereview.chromium.org/1563005/diff/2001/3005#newcode898
src/heap.h:898: static Object* AllocateRawFixedArray(int length,
The other functions have a default PretenureFlag argument. Why is this
one overloaded?
http://codereview.chromium.org/1563005/diff/2001/3006
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1563005/diff/2001/3006#newcode6508
src/ia32/codegen-ia32.cc:6508: cache.ToRegister();
key and cache could be the same register (if we had JS code
%_GetFromCache(x, x)). Since that shouldn't be the case (we control the
call site), maybe assert that !key.reg().is(cache.reg()).
http://codereview.chromium.org/1563005
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
