http://codereview.chromium.org/1563005/diff/2001/3006 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1563005/diff/2001/3006#newcode6508 src/ia32/codegen-ia32.cc:6508: cache.ToRegister(); On 2010/04/07 15:31:56, Kevin Millikin wrote:
On 2010/04/07 15:01:35, antonm wrote: > On 2010/04/07 13:34:36, Kevin Millikin wrote: > > key and cache could be the same register (if we had JS code %_GetFromCache(x, > > x)). Since that shouldn't be the case (we control the call site),
maybe
> assert > > that !key.reg().is(cache.reg()). > > Kevin, I quite agree that they always should be different. However,
way
assert > that? It looks like the rest of the code doesn't depend on this
assumption.
> > Still adding ASSERT.
Actually you're right. I must have misread cmp as mov. Disregard :)
Thanks, Kevin. Disregarded :) http://codereview.chromium.org/1563005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
