Please cleanup the #ifdef comments. Other than that LGTM.
http://codereview.chromium.org/1635001/diff/1/13 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1635001/diff/1/13#newcode10930 src/ia32/codegen-ia32.cc:10930: #endif // ndef V8_INTERPRETED_REGEXP This is ending an ifdef not an ifndef. http://codereview.chromium.org/1635001/diff/1/14 File src/ia32/regexp-macro-assembler-ia32.h (right): http://codereview.chromium.org/1635001/diff/1/14#newcode211 src/ia32/regexp-macro-assembler-ia32.h:211: #endif // ndef V8_INTERPRETED_REGEXP Ditto. http://codereview.chromium.org/1635001/diff/1/28 File src/jsregexp.cc (right): http://codereview.chromium.org/1635001/diff/1/28#newcode368 src/jsregexp.cc:368: #endif // !V8_INTERPRETED_REGEXP Remove !. http://codereview.chromium.org/1635001/diff/1/28#newcode436 src/jsregexp.cc:436: #endif // def V8_INTERPRETED_REGEXP ndef The mix of def, ndef, and ! in these comments is a mess. Maybe we should clean it up now that we have them all identified. http://codereview.chromium.org/1635001/diff/1/28#newcode5252 src/jsregexp.cc:5252: #endif // def V8_INTERPRETED_REGEXP ndef http://codereview.chromium.org/1635001/diff/1/21 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1635001/diff/1/21#newcode7290 src/x64/codegen-x64.cc:7290: #endif // ndef V8_INTERPRETED_REGEXP def http://codereview.chromium.org/1635001/diff/1/3 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/1635001/diff/1/3#newcode56 test/cctest/test-regexp.cc:56: #endif // ndef V8_INTERPRETED_REGEXP def http://codereview.chromium.org/1635001/diff/1/3#newcode1335 test/cctest/test-regexp.cc:1335: #endif // def V8_INTERPRETED_REGEXP ndef http://codereview.chromium.org/1635001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
