LGTM!
http://codereview.chromium.org/1635001/diff/23001/6018 File src/assembler.h (right): http://codereview.chromium.org/1635001/diff/23001/6018#newcode459 src/assembler.h:459: #ifndef V8_INTERPRETED_REGEXP Missing comment on related #endif? http://codereview.chromium.org/1635001/diff/23001/6027 File src/heap.h (right): http://codereview.chromium.org/1635001/diff/23001/6027#newcode114 src/heap.h:114: #if V8_TARGET_ARCH_ARM && !V8_INTERPRETED_REGEXP Missing comment on #else and #endif, but I think thats fine here with them being so close together. http://codereview.chromium.org/1635001/diff/23001/6028 File src/jsregexp.cc (right): http://codereview.chromium.org/1635001/diff/23001/6028#newcode242 src/jsregexp.cc:242: #endif Add comment here or remove from #else http://codereview.chromium.org/1635001/diff/23001/6021 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1635001/diff/23001/6021#newcode7922 src/x64/codegen-x64.cc:7922: #endif Comment here as well. http://codereview.chromium.org/1635001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
