Reviewers: Søren Gjesse, Message: Thanks!
Yes, it is now possible to merge CPP_PROFILES_PROCESSOR defines with LOGGING_AND_PROFILING. I'm leaving them mainly for two reasons: - explicitly highlighting the new code for other developers, and; - being able to cloak the new code in case if something goes wrong. http://codereview.chromium.org/1635005/diff/2001/3002 File src/cpu-profiler-inl.h (right): http://codereview.chromium.org/1635005/diff/2001/3002#newcode64 src/cpu-profiler-inl.h:64: result->filler = 1; // != SamplingCircularQueue::kClear. On 2010/04/12 06:56:28, Søren Gjesse wrote:
Please add
ASSERT(result->filler = != SamplingCircularQueue::kClear);
Done. Description: Allow new CPU profiling subsystem to coexist nicely with the old one. This is to make possible enabling usage of the new profiling subsystem in Chromium without much hassle. The idea is pretty simple: unless the new profiling API is used, all works as usual, as soon as Chromium starts to use the new API, it will work too. Please review this at http://codereview.chromium.org/1635005/show Affected files: M SConstruct M src/cpu-profiler-inl.h M src/cpu-profiler.h M src/cpu-profiler.cc M src/flag-definitions.h M src/globals.h M src/log.h M src/log.cc M src/platform-linux.cc M src/platform-macos.cc M src/platform-win32.cc M src/v8.cc M test/cctest/test-cpu-profiler.cc M test/cctest/test-profile-generator.cc M tools/gyp/v8.gyp -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
