LGTM
http://codereview.chromium.org/1631008/diff/1/4 File src/assembler.h (right): http://codereview.chromium.org/1631008/diff/1/4#newcode401 src/assembler.h:401: static ExternalReference fill_heap_number_with_random_function(); Do we still need this? http://codereview.chromium.org/1631008/diff/1/6 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/1631008/diff/1/6#newcode2388 src/x64/assembler-x64.cc:2388: void Assembler::movd(XMMRegister dst, const Register src) { I don't think we normally use const on src registers? http://codereview.chromium.org/1631008/diff/1/7 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/1631008/diff/1/7#newcode1108 src/x64/assembler-x64.h:1108: // The first argument is the reg field, the second argument is the r/m field. I do not get this comment - how can an XMMRegister be a memory field? http://codereview.chromium.org/1631008/diff/1/8 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1631008/diff/1/8#newcode4105 src/x64/codegen-x64.cc:4105: ASSERT (CpuFeatures::IsSupported(SSE2)); no space after ASSERT http://codereview.chromium.org/1631008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
