LGTM
http://codereview.chromium.org/1700005/diff/6001/7004 File src/mark-compact.cc (right): http://codereview.chromium.org/1700005/diff/6001/7004#newcode1396 src/mark-compact.cc:1396: ASSERT(((first_empty_page == NULL) && Now that you have an #ifdef DEBUG here in any case it would be more readable with ifs and multiple ASSERTS. :) Another small comment: Kevin made me aware that Page has an is_valid() method that can be used instead of explicit checking Page pointers against NULL. Also, it seems that in most other code, we use Page::FromAddress(NULL) instead of using NULL explicitly in initializations. http://codereview.chromium.org/1700005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
