LGTM
http://codereview.chromium.org/1869001/diff/1002/3002 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1869001/diff/1002/3002#newcode2174 src/ia32/codegen-ia32.cc:2174: TypeInfo right_type_info = operand.type_info(); Why make a variable for something that's only used once anyway? Is the information lost in the register shuffling below? http://codereview.chromium.org/1869001/diff/1002/3002#newcode2200 src/ia32/codegen-ia32.cc:2200: } else { Consider using } else if (...) { http://codereview.chromium.org/1869001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
