http://codereview.chromium.org/1869001/diff/1002/3002
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1869001/diff/1002/3002#newcode2174
src/ia32/codegen-ia32.cc:2174: TypeInfo right_type_info =
operand.type_info();
On 2010/05/04 07:48:20, Lasse Reichstein wrote:
Why make a variable for something that's only used once anyway? Is the
information lost in the register shuffling below?
Exactly, the information is lost in the register shuffling below.
http://codereview.chromium.org/1869001/diff/1002/3002#newcode2200
src/ia32/codegen-ia32.cc:2200: } else {
On 2010/05/04 07:48:20, Lasse Reichstein wrote:
Consider using
} else if (...) {
Done.
http://codereview.chromium.org/1869001/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
