LGTM and thanks a lot for port.
http://codereview.chromium.org/1689010/diff/9001/10003 File src/x64/codegen-x64.h (right): http://codereview.chromium.org/1689010/diff/9001/10003#newcode1014 src/x64/codegen-x64.h:1014: class RecordWriteStub : public CodeStub { I think Mads already has ported that to x64 :) http://codereview.chromium.org/1689010/diff/9001/10006 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/1689010/diff/9001/10006#newcode567 src/x64/stub-cache-x64.cc:567: __ movq(scratch, Operand(rsp, 0)); I am fine if you keep those changes here. But it might be a good idea to extend CL description. Or maybe do it in a separate CL as all modifications in this file are not related to array's push/pop http://codereview.chromium.org/1689010/diff/9001/10007 File test/mjsunit/array-pop.js (right): http://codereview.chromium.org/1689010/diff/9001/10007#newcode72 test/mjsunit/array-pop.js:72: assertEquals(j+1, a.length, "inherit-pre-length"); should + be surrounded with space? http://codereview.chromium.org/1689010/diff/9001/10007#newcode72 test/mjsunit/array-pop.js:72: assertEquals(j+1, a.length, "inherit-pre-length"); do you want add j to message, something like "inherit-pre-length-" + j? http://codereview.chromium.org/1689010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
