http://codereview.chromium.org/1689010/diff/9001/10003 File src/x64/codegen-x64.h (right):
http://codereview.chromium.org/1689010/diff/9001/10003#newcode1014 src/x64/codegen-x64.h:1014: class RecordWriteStub : public CodeStub { Correct, it got me a few merge failures when forwarding my change to head of bleeding_edge (but only in indentation and comments, the code must be obvious). http://codereview.chromium.org/1689010/diff/9001/10006 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/1689010/diff/9001/10006#newcode567 src/x64/stub-cache-x64.cc:567: __ movq(scratch, Operand(rsp, 0)); Will modify CL description. http://codereview.chromium.org/1689010/diff/9001/10007 File test/mjsunit/array-pop.js (right): http://codereview.chromium.org/1689010/diff/9001/10007#newcode72 test/mjsunit/array-pop.js:72: assertEquals(j+1, a.length, "inherit-pre-length"); On 2010/05/04 12:42:45, antonm wrote:
should + be surrounded with space?
Done. http://codereview.chromium.org/1689010/diff/9001/10007#newcode72 test/mjsunit/array-pop.js:72: assertEquals(j+1, a.length, "inherit-pre-length"); Good idea. Done. http://codereview.chromium.org/1689010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
