http://codereview.chromium.org/1910005/diff/15001/16003 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1910005/diff/15001/16003#newcode8500 src/arm/codegen-arm.cc:8500: // Check that the third argument is a positive smi not greater than the Please restore comment. http://codereview.chromium.org/1910005/diff/15001/16001 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1910005/diff/15001/16001#newcode10955 src/ia32/codegen-ia32.cc:10955: // Check that the third argument is a positive smi not greater than the The index should be less than the length. So please restore this comment. http://codereview.chromium.org/1910005/diff/15001/16001#newcode10962 src/ia32/codegen-ia32.cc:10962: __ j(above, &runtime); This actually should be above_equal. The index should be less than the subject length. http://codereview.chromium.org/1910005/diff/15001/16002 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1910005/diff/15001/16002#newcode8136 src/x64/codegen-x64.cc:8136: // Check that the third argument is a positive smi not greater than the Please restore old comment. http://codereview.chromium.org/1910005/diff/15001/16002#newcode8142 src/x64/codegen-x64.cc:8142: __ j(above, &runtime); above_equal is correct I think. The index should be less than the string length. http://codereview.chromium.org/1910005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
