The condition determines place where the corner case is handled. I checked
both
ways (http://compute1.aar:9013/golem/r4596-v8-serya-perf-1-vs-4596-v8.html
and
http://compute1.aar:9013/golem/r4596-v8-serya-perf-2-vs-4596-v8.html).
Anyway
it's less important than wrong check for smi and should be measured
independently (and may be fixed separately).
http://codereview.chromium.org/1910005/diff/15001/16003
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1910005/diff/15001/16003#newcode8500
src/arm/codegen-arm.cc:8500: // Check that the third argument is a
positive smi not greater than the
On 2010/05/06 09:42:19, Mads Ager wrote:
Please restore comment.
Done.
http://codereview.chromium.org/1910005/diff/15001/16001
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1910005/diff/15001/16001#newcode10955
src/ia32/codegen-ia32.cc:10955: // Check that the third argument is a
positive smi not greater than the
On 2010/05/06 09:42:19, Mads Ager wrote:
The index should be less than the length. So please restore this
comment.
Done.
http://codereview.chromium.org/1910005/diff/15001/16001#newcode10962
src/ia32/codegen-ia32.cc:10962: __ j(above, &runtime);
On 2010/05/06 09:42:19, Mads Ager wrote:
This actually should be above_equal. The index should be less than the
subject
length.
Done.
http://codereview.chromium.org/1910005/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
