LGTM with comments.
http://codereview.chromium.org/2024002/diff/8001/9002 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2024002/diff/8001/9002#newcode5749 src/arm/codegen-arm.cc:5749: if (VirtualFrame::SpilledScope::is_spilled()) { Can't we move this into Dup2()? http://codereview.chromium.org/2024002/diff/8001/9006 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2024002/diff/8001/9006#newcode1064 src/arm/ic-arm.cc:1064: GenerateUInt2Double(masm, value, loword, r4, 0); value -> hiword http://codereview.chromium.org/2024002/diff/8001/9006#newcode1069 src/arm/ic-arm.cc:1069: GenerateUInt2Double(masm, value, loword, r4, 1); value -> hiword http://codereview.chromium.org/2024002/diff/8001/9006#newcode1075 src/arm/ic-arm.cc:1075: // more. Also OK to clobber r1. OK to clobber r1 if the allocation succeeds, but AllocateHeapNumber seems to clobber r1 regardless! http://codereview.chromium.org/2024002/diff/8001/9004 File src/arm/virtual-frame-arm.cc (right): http://codereview.chromium.org/2024002/diff/8001/9004#newcode542 src/arm/virtual-frame-arm.cc:542: __ push(r1); Oops! http://codereview.chromium.org/2024002/diff/8001/9004#newcode548 src/arm/virtual-frame-arm.cc:548: __ push(r1); Hmmm. http://codereview.chromium.org/2024002/diff/8001/9004#newcode554 src/arm/virtual-frame-arm.cc:554: __ push(r0); I don't get it. http://codereview.chromium.org/2024002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
