http://codereview.chromium.org/2024002/diff/8001/9002 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2024002/diff/8001/9002#newcode5749 src/arm/codegen-arm.cc:5749: if (VirtualFrame::SpilledScope::is_spilled()) { On 2010/05/07 08:53:25, Erik Corry wrote:
Can't we move this into Dup2()?
Done. It needs a temporary register, which is why I did not do it in the first place, but I can see the virtual frame can use ip. http://codereview.chromium.org/2024002/diff/8001/9006 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2024002/diff/8001/9006#newcode1064 src/arm/ic-arm.cc:1064: GenerateUInt2Double(masm, value, loword, r4, 0); On 2010/05/07 08:53:25, Erik Corry wrote:
value -> hiword
Done. http://codereview.chromium.org/2024002/diff/8001/9006#newcode1069 src/arm/ic-arm.cc:1069: GenerateUInt2Double(masm, value, loword, r4, 1); On 2010/05/07 08:53:25, Erik Corry wrote:
value -> hiword
Done. http://codereview.chromium.org/2024002/diff/8001/9006#newcode1075 src/arm/ic-arm.cc:1075: // more. Also OK to clobber r1. On 2010/05/07 08:53:25, Erik Corry wrote:
OK to clobber r1 if the allocation succeeds, but AllocateHeapNumber
seems to
clobber r1 regardless!
Good catch! Removed the comment on both r0 and r1 and used r2 and r3 instead. Fixed all the other uses AllocateHeapNumber below to avoid clobbering r0 and r1 before any possible bailouts to the slow case. http://codereview.chromium.org/2024002/diff/8001/9004 File src/arm/virtual-frame-arm.cc (right): http://codereview.chromium.org/2024002/diff/8001/9004#newcode542 src/arm/virtual-frame-arm.cc:542: __ push(r1); On 2010/05/07 08:53:25, Erik Corry wrote:
Oops!
Done. This path is not hit by the tests. http://codereview.chromium.org/2024002/diff/8001/9004#newcode548 src/arm/virtual-frame-arm.cc:548: __ push(r1); On 2010/05/07 08:53:25, Erik Corry wrote:
Hmmm.
What a mess - fixed. Also this path is not hit by the tests. http://codereview.chromium.org/2024002/diff/8001/9004#newcode554 src/arm/virtual-frame-arm.cc:554: __ push(r0); On 2010/05/07 08:53:25, Erik Corry wrote:
I don't get it.
And fixed again. Also this path is not hit by the tests. http://codereview.chromium.org/2024002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
