I fixed the remaining issues (see below) and committed this as r4618.
http://codereview.chromium.org/2019003/diff/39001/7009 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/2019003/diff/39001/7009#newcode450 src/arm/assembler-arm.h:450: void set_offset(int32_t offset) { I added single spaces around these functions to match the style of the surrounding code. http://codereview.chromium.org/2019003/diff/39001/7013 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/2019003/diff/39001/7013#newcode1013 src/arm/simulator-arm.cc:1013: int32_t* ptr = reinterpret_cast<int32_t *>(addr); I removed a space here for you. http://codereview.chromium.org/2019003/diff/39001/7013#newcode1018 src/arm/simulator-arm.cc:1018: return *ptr; I don't see how this compiles. It should be returning an int32_t*, not an intptr_t. http://codereview.chromium.org/2019003/diff/39001/7013#newcode1040 src/arm/simulator-arm.cc:1040: PrintF("Unaligned write at 0x%08x, pc=%p\n", addr, instr); There's no variable called instr here so this doesn't compile either. Fixed for you. http://codereview.chromium.org/2019003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
