LGTM
http://codereview.chromium.org/2053003/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2053003/diff/1/2#newcode2768 src/arm/codegen-arm.cc:2768: // spilled when jumping to these targets. Not actually true any more :-). But we will be fixing these in new changes over the next weeks. http://codereview.chromium.org/2053003/diff/1/2#newcode3777 src/arm/codegen-arm.cc:3777: call.Jump(); call is only used inside these {} so it would be clearer to move the declaration down here. http://codereview.chromium.org/2053003/diff/1/2#newcode3779 src/arm/codegen-arm.cc:3779: frame_->EmitPush(r0); // function Comments without caps and full stops are like gas cookers without safety valves. They don't need to be fixed unless you move them :-). http://codereview.chromium.org/2053003/diff/1/5 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/2053003/diff/1/5#newcode462 src/ia32/codegen-ia32.h:462: // types. So it expects to fall through to the 'slow' target? Perhaps we should document that. http://codereview.chromium.org/2053003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
