http://codereview.chromium.org/2053003/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2053003/diff/1/2#newcode2768
src/arm/codegen-arm.cc:2768: // spilled when jumping to these targets.
On 2010/05/12 07:52:57, Erik Corry wrote:
Not actually true any more :-). But we will be fixing these in new
changes over
the next weeks.
Sounds great! :)
http://codereview.chromium.org/2053003/diff/1/2#newcode3777
src/arm/codegen-arm.cc:3777: call.Jump();
On 2010/05/12 07:52:57, Erik Corry wrote:
call is only used inside these {} so it would be clearer to move the
declaration
down here.
Done.
http://codereview.chromium.org/2053003/diff/1/2#newcode3779
src/arm/codegen-arm.cc:3779: frame_->EmitPush(r0); // function
On 2010/05/12 07:52:57, Erik Corry wrote:
Comments without caps and full stops are like gas cookers without
safety valves.
They don't need to be fixed unless you move them :-).
Yeah, most end-of-line comments like these are without caps and full
stops, so I left it this way.
http://codereview.chromium.org/2053003/diff/1/5
File src/ia32/codegen-ia32.h (right):
http://codereview.chromium.org/2053003/diff/1/5#newcode462
src/ia32/codegen-ia32.h:462: // types.
On 2010/05/12 07:52:57, Erik Corry wrote:
So it expects to fall through to the 'slow' target? Perhaps we should
document
that.
Done.
http://codereview.chromium.org/2053003/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
