Reviewers: fschneider, Lasse Reichstein, Erik Corry, antonm,

Message:
I suggest the following division of labour:

fschneider: Please look at the ia32 part and the platform independent parts

lrn: Please look at the x64 part

erik.corry: Please look at the ARM part

antonm: Please look at FullCodeGenerator::EmitGetFromCache. In there I have
adapted the code from the defered code object DeferredSearchCache in the virtual
frame based compiler between #if 0 and #endif, and I currently call
Runtime_GetFromCache instead of using that code. The code between #if 0 and
#endif pass all the tests, so do you think it makes sense to have that code in the full compiler as well as in the virtual frame based one or should we rely on
the single use of %_GetFromCache in strings.js being compiled by the virtual
frame based compiler? Maybe just moving the code from defered code object
DeferredSearchCache into a stub will work and we can use it from both places.

Description:
Add complete implementation of full compiler for the ia32 architecture

This makes the full compiler handle all constructs on ia32 and the syntax
checker for the full compiler is disabled on ia32. This is on preparation for improving the debugger break point experience where the plan is to only use code
from full code generator when debugging JavaScript.

Runs all tests on all three platforms in release and debug mode. The tests also
run with both the following flags to the test runner

  --special-command="@ --nofull-compiler"
  --special-command="@ --always-full-compiler"

The changes to the x64 and ARM architectures are mainly structural due to the change to EmitVariableAssignment to handle initialization of const variables.

I will update the TODO(XXX) in test/cctest/test-log-stack-tracer.cc to a real
bug number before comitting.

Please review this at http://codereview.chromium.org/1989012/show

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/arm/full-codegen-arm.cc
  M     src/codegen.h
  M     src/compiler.cc
  M     src/full-codegen.h
  M     src/full-codegen.cc
  M     src/ia32/full-codegen-ia32.cc
  M     src/x64/full-codegen-x64.cc
  M     test/cctest/test-log-stack-tracer.cc


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to