Looks good to me. All those register changes made steam come out of my
ears,
but it's nice to know you ran all the tests with all those flags.
http://codereview.chromium.org/2116003/diff/10001/11005
File src/arm/ic-arm.cc (right):
http://codereview.chromium.org/2116003/diff/10001/11005#newcode1332
src/arm/ic-arm.cc:1332: // Condition code from comparing key and array
length is still available.
Thanks for that comment!
http://codereview.chromium.org/2116003/diff/10001/11005#newcode1341
src/arm/ic-arm.cc:1341: __ add(r4, key, Operand(1 << (kSmiTagSize +
kSmiShiftSize)));
Operand(Smi::FromInt(1))
http://codereview.chromium.org/2116003/diff/10001/11005#newcode1368
src/arm/ic-arm.cc:1368: __ b(eq, &exit);
I think you might as well do a Ret(eq) here.
http://codereview.chromium.org/2116003/diff/10001/11005#newcode1555
src/arm/ic-arm.cc:1555: // r3: base pointer of external storage
Full stop here and lots of other places.
http://codereview.chromium.org/2116003/diff/10001/11007
File src/arm/virtual-frame-arm.cc (right):
http://codereview.chromium.org/2116003/diff/10001/11007#newcode344
src/arm/virtual-frame-arm.cc:344: EmitPop(r2);
This pop and the spillall should be swapped, since we plan to register
allocate r2 soon.
http://codereview.chromium.org/2116003/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
