http://codereview.chromium.org/2116003/diff/10001/11005 File src/arm/ic-arm.cc (right):
http://codereview.chromium.org/2116003/diff/10001/11005#newcode1341 src/arm/ic-arm.cc:1341: __ add(r4, key, Operand(1 << (kSmiTagSize + kSmiShiftSize))); On 2010/05/17 19:15:15, Erik Corry wrote:
Operand(Smi::FromInt(1))
Done. http://codereview.chromium.org/2116003/diff/10001/11005#newcode1368 src/arm/ic-arm.cc:1368: __ b(eq, &exit); On 2010/05/17 19:15:15, Erik Corry wrote:
I think you might as well do a Ret(eq) here.
Done. http://codereview.chromium.org/2116003/diff/10001/11005#newcode1555 src/arm/ic-arm.cc:1555: // r3: base pointer of external storage On 2010/05/17 19:15:15, Erik Corry wrote:
Full stop here and lots of other places.
Done. http://codereview.chromium.org/2116003/diff/10001/11007 File src/arm/virtual-frame-arm.cc (right): http://codereview.chromium.org/2116003/diff/10001/11007#newcode344 src/arm/virtual-frame-arm.cc:344: EmitPop(r2); On 2010/05/17 19:15:15, Erik Corry wrote:
This pop and the spillall should be swapped, since we plan to register
allocate
r2 soon.
Done. http://codereview.chromium.org/2116003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
