http://codereview.chromium.org/2087009/diff/1/3 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/2087009/diff/1/3#newcode6133 src/ia32/codegen-ia32.cc:6133: deferred->fast_case_generator()->GenerateFast(masm_); It seems backwards to me that the deferred code object has a generator for the fast case code. I would rather have something here that generates the fast case code and uses the deferred code object for bailouts from that. Maybe that means having static methods for the fast/slow case generation of CharCodeAt that takes registers and labels as arguments? http://codereview.chromium.org/2087009/diff/1/3#newcode12645 src/ia32/codegen-ia32.cc:12645: __ Abort("CharCodeAt slow case reached"); I guess the problem here is not that a slow case is reached, but that we fall through to the slow case where we are expected to jump to one of the labels instead. Could you make the Abort message reflect that? http://codereview.chromium.org/2087009/diff/1/4 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/2087009/diff/1/4#newcode922 src/ia32/codegen-ia32.h:922: // Register usage: |object| may be changed to another string in way in way -> in a way http://codereview.chromium.org/2087009/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
