LGTM
http://codereview.chromium.org/2087009/diff/16001/17006 File src/codegen.h (right): http://codereview.chromium.org/2087009/diff/16001/17006#newcode691 src/codegen.h:691: enum StringIndexFlags { How about renaming these to something like: INDEX_IS_NUMBER INDEX_IS_ARRAY_INDEX I think that makes it easier to read at the call site. I would also like the comments on the generators to say how the code generated depends on these flags. http://codereview.chromium.org/2087009/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
