Reviewers: ,
Message:
Changes from initial CL marked by comments.
http://codereview.chromium.org/2114015/diff/1/11
File src/heap.cc (right):
http://codereview.chromium.org/2114015/diff/1/11#newcode3331
src/heap.cc:3331:
Improved heap verification here. Now all regions are search for garbage
pointers to new space.
http://codereview.chromium.org/2114015/diff/1/28
File src/spaces-inl.h (right):
http://codereview.chromium.org/2114015/diff/1/28#newcode79
src/spaces-inl.h:79: return static_cast<uint32_t>((flags_ &
kAllocationWatermarkOffsetMask) >>
Added cast to fix compilation on Win64
http://codereview.chromium.org/2114015/diff/1/28#newcode146
src/spaces-inl.h:146: return static_cast<int>(offset_inside_normal_page
kRegionSizeLog2);
Added cast to fix compilation on Win64
Description:
Cardmarking writebarrier.
Reapplication of r4685 (reviewed http://codereview.chromium.org/2101002)
with
minor modifications:
- Fix compilation problems on Win64.
- Improve heap verification pass: search for garbage pointers to new space
not
only in dirty regions but in all regions.
Please review this at http://codereview.chromium.org/2114015/show
Affected files:
M src/arm/builtins-arm.cc
M src/arm/codegen-arm.cc
M src/arm/ic-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/builtins.cc
M src/flag-definitions.h
M src/globals.h
M src/heap-inl.h
M src/heap.h
M src/heap.cc
M src/ia32/builtins-ia32.cc
M src/ia32/codegen-ia32.h
M src/ia32/codegen-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/ic-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/ia32/stub-cache-ia32.cc
M src/mark-compact.h
M src/mark-compact.cc
M src/objects-debug.cc
M src/objects-inl.h
M src/objects.h
src/objects.cc
M src/runtime.cc
M src/spaces-inl.h
M src/spaces.h
M src/spaces.cc
M src/x64/builtins-x64.cc
M src/x64/codegen-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/ic-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
M src/x64/stub-cache-x64.cc
M test/cctest/test-heap.cc
M test/cctest/test-spaces.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
