LGTM

http://codereview.chromium.org/2080018/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/2080018/diff/1/3#newcode5
ChangeLog:5: Use 'full compiler' when debugging is active.  Page reload
may be
I think "Page reload may be needed" should be changed to something like
"This will only take effect for functions compiled after debugging has
been started, so recompilation of all functions is required to get the
full effect" and moved to after "... fine grained.".

http://codereview.chromium.org/2080018/diff/1/3#newcode13
ChangeLog:13: Improve security when CPU profiling.
I think this should be changed to something like "Add filtering of CPU
profiles by security context".

http://codereview.chromium.org/2080018/diff/1/3#newcode15
ChangeLog:15: Fix crash bug on ARM when running without VFP.
VFP ->VFP3?

http://codereview.chromium.org/2080018/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to