First pass. I overall like the approach, but think that we need Mads' blessing anyway.
Could we refactor argc, in_loop and call_mode into a small structure (or just
thread flags around)? http://codereview.chromium.org/2280007/diff/1/16 File src/codegen.cc (right): http://codereview.chromium.org/2280007/diff/1/16#newcode258 src/codegen.cc:258: StubCache::ComputeCallInitialize(argc, in_loop, FIXED_NAME), Code); NAMED_CALL? http://codereview.chromium.org/2280007/diff/1/5 File src/globals.h (right): http://codereview.chromium.org/2280007/diff/1/5#newcode462 src/globals.h:462: FIXED_NAME, sorry for repetition: I'd prefer to see NAMED_CALL/MODE, KEYED_CALL/MODE http://codereview.chromium.org/2280007/diff/1/6 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2280007/diff/1/6#newcode5963 src/ia32/codegen-ia32.cc:5963: // Push the name of the function onto the frame. Load the name? http://codereview.chromium.org/2280007/diff/1/8 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/2280007/diff/1/8#newcode597 src/ia32/codegen-ia32.h:597: static Handle<Code> ComputeCallInitialize( only for ia32? http://codereview.chromium.org/2280007/diff/1/7 File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/2280007/diff/1/7#newcode1860 src/ia32/full-codegen-ia32.cc:1860: // instruction after the call it is treated specially the call <as> it is ? I see you just moved it, but maybe you can correct while you're here. http://codereview.chromium.org/2280007/diff/1/13 File src/ic.cc (right): http://codereview.chromium.org/2280007/diff/1/13#newcode160 src/ic.cc:160: (kind == Code::CALL_IC && target->ic_call_mode() == VARIABLE_NAME)) { why you added CallIIC case check here? http://codereview.chromium.org/2280007/diff/1/13#newcode1374 src/ic.cc:1374: ic.KeyedLoadFunction(state, args.at<Object>(0), args.at<Object>(1)); nit: indent, I'd add two more spaces http://codereview.chromium.org/2280007/diff/1/13#newcode1376 src/ic.cc:1376: // The first time the inline cache is updated may be the first time the I wonder if the code below should be refactored into a separate function. http://codereview.chromium.org/2280007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
