That looks mostly LGTM. But I really would like to see tons of tests for various transitions.
http://codereview.chromium.org/2280007/diff/20001/21005 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2280007/diff/20001/21005#newcode5953 src/ia32/codegen-ia32.cc:5953: Load(property->obj()); nit: maybe unify with lines 5917--5936 (add a comment, blank line) http://codereview.chromium.org/2280007/diff/20001/21011 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/2280007/diff/20001/21011#newcode1110 src/ia32/ic-ia32.cc:1110: __ EnterInternalFrame(); why enter/exit internal frame here? http://codereview.chromium.org/2280007/diff/20001/21011#newcode1131 src/ia32/ic-ia32.cc:1131: // -- edi : function to call (if lookup=true) if lookup != true? http://codereview.chromium.org/2280007/diff/20001/21012 File src/ic.cc (right): http://codereview.chromium.org/2280007/diff/20001/21012#newcode160 src/ic.cc:160: target->ic_call_mode() == KEYED_CALL) { shouldn't you check CALL_IC kind before? http://codereview.chromium.org/2280007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
