http://codereview.chromium.org/2310003/diff/1/4 File src/isolate.h (right):
http://codereview.chromium.org/2310003/diff/1/4#newcode40 src/isolate.h:40: static Isolate* current(); I think we should only allow lazy initialization in the API layer. Internally we should be able to assume the current isolate already exists. One of the reasons is that getting the current isolate is a performance critical thing. Comment on naming: Isolate::current() makes the reader think it's so fast that it doesn't really make sense to cache it in a local variable. While we'd like this to be the case, it still will be slower than that. So Isolate::GetCurrent() is a better name. http://codereview.chromium.org/2310003/diff/1/4#newcode51 src/isolate.h:51: bool InitializeFromInternalV8Temp(Deserializer* des); We'll have a lot of temporary things in this branch. I don't think they deserve a separate naming convention. http://codereview.chromium.org/2310003/diff/1/5 File src/v8.cc (right): http://codereview.chromium.org/2310003/diff/1/5#newcode56 src/v8.cc:56: return Isolate::current()->InitializeFromInternalV8Temp(des); What about initialization that shouldn't be done for each isolate? E.g. OS::Setup(), CPU features probing? We should split initialization into global and per-isolate functions. http://codereview.chromium.org/2310003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
