http://codereview.chromium.org/2310003/diff/14001/10003 File src/isolate.cc (right):
http://codereview.chromium.org/2310003/diff/14001/10003#newcode56 src/isolate.cc:56: Isolate* newIsolate = new Isolate(); No camel case please. Use this_style for locals. http://codereview.chromium.org/2310003/diff/14001/10004 File src/isolate.h (right): http://codereview.chromium.org/2310003/diff/14001/10004#newcode39 src/isolate.h:39: static Isolate* Current(); Make this an inline function. (Declare the static field here and define it in the .cc file.) http://codereview.chromium.org/2310003/diff/14001/10004#newcode43 src/isolate.h:43: static Isolate* Init(Deserializer* des); "Create"? "New"? http://codereview.chromium.org/2310003/diff/14001/10004#newcode49 src/isolate.h:49: void TearDown(); Should this just be ~Isolate for now? I don't think we can use an isolate after it has been torn down. http://codereview.chromium.org/2310003/diff/14001/10004#newcode54 src/isolate.h:54: bool InitInternal(Deserializer* des); "Init"? http://codereview.chromium.org/2310003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
