LGTM with issues addressed.

http://codereview.chromium.org/2469002/diff/1/3
File src/bootstrapper.h (right):

http://codereview.chromium.org/2469002/diff/1/3#newcode101
src/bootstrapper.h:101: DISALLOW_COPY_AND_ASSIGN(Bootstrapper);
DISALLOW_IMPLICIT_CONSTRUCTORS also disables the default constructor.

http://codereview.chromium.org/2469002/diff/1/4
File src/isolate.cc (right):

http://codereview.chromium.org/2469002/diff/1/4#newcode85
src/isolate.cc:85: bootstrapper_ = new Bootstrapper();
This should be below DisallowAllocationFailure.

http://codereview.chromium.org/2469002/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to