LGTM.

http://codereview.chromium.org/2469001/diff/1/2
File src/ic.cc (right):

http://codereview.chromium.org/2469001/diff/1/2#newcode845
src/ic.cc:845: code
=Isolate::Current()->stub_cache()->ComputeKeyedLoadStringLength(
nit: Missing space after '='.

http://codereview.chromium.org/2469001/diff/1/3
File src/isolate.cc (right):

http://codereview.chromium.org/2469001/diff/1/3#newcode82
src/isolate.cc:82: stub_cache_ = new StubCache();
Should be below DisallowAllocationFailure.

http://codereview.chromium.org/2469001/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to