LGTM
http://codereview.chromium.org/2476001/diff/1/2 File src/api.cc (right): http://codereview.chromium.org/2476001/diff/1/2#newcode446 src/api.cc:446: EnsureInitialized("HandleScope::HandleScope"); Please add comment describing why this is required. http://codereview.chromium.org/2476001/diff/1/2#newcode3052 src/api.cc:3052: // Make sure the initialization did not leave allocated handles in Does NoHandleAllocation work here? http://codereview.chromium.org/2476001/diff/1/5 File src/handles.cc (right): http://codereview.chromium.org/2476001/diff/1/5#newcode58 src/handles.cc:58: Isolate::Current()->handle_scope_data(); Ditto. http://codereview.chromium.org/2476001/diff/1/5#newcode98 src/handles.cc:98: Isolate::Current()->handle_scope_data(); Ditto. http://codereview.chromium.org/2476001/diff/1/6 File src/handles.h (right): http://codereview.chromium.org/2476001/diff/1/6#newcode125 src/handles.h:125: Isolate::Current()->handle_scope_data(); nit: 4 space indent on line continuations. http://codereview.chromium.org/2476001/diff/1/6#newcode159 src/handles.h:159: Isolate::Current()->handle_scope_data(); Ditto. http://codereview.chromium.org/2476001/diff/1/6#newcode169 src/handles.h:169: Isolate::Current()->handle_scope_data(); Ditto. http://codereview.chromium.org/2476001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
