All fixed, and I additionally modified tests in test-serialize.
They used the sequence:
HandleScope scope;
Deserialize(); // from test file
which was not reading the file at all because HandleScope would already
initialize the default isolate, so the attempt to initialize it again by
deserializer will just immediately return. Moved HandleScope constructor
below
Initialize() call, or removed it at all if no handles are created in the
test.
Since we don't expose deserialization in API it seems ok.
http://codereview.chromium.org/2476001/diff/1/2#newcode3052
src/api.cc:3052: // Make sure the initialization did not leave allocated
handles
in
Does NoHandleAllocation work here?
It wouldn't work here because first thing its constructor does is to create
a
HandleScope again, before current isolate is initialized. But even better -
we
don't need any checks because there is already one in HandleScope::Extend
that
would call ReportApiFailure(...) if there is no scope on the stack on
attempt to
create a handle.
http://codereview.chromium.org/2476001/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
