LGTM
http://codereview.chromium.org/2493002/diff/9003/32002 File src/isolate.cc (right): http://codereview.chromium.org/2493002/diff/9003/32002#newcode71 src/isolate.cc:71: name##_ = initialvalue; Use "(initial_value)" just in case. http://codereview.chromium.org/2493002/diff/9003/32003 File src/isolate.h (right): http://codereview.chromium.org/2493002/diff/9003/32003#newcode59 src/isolate.h:59: ~Isolate(); BTW, according to the style guide this should be the first thing in this class. http://codereview.chromium.org/2493002/diff/9003/32003#newcode105 src/isolate.h:105: #define STATIC_CLASS class Do we really need this? http://codereview.chromium.org/2493002/diff/9003/32006 File src/zone-inl.h (right): http://codereview.chromium.org/2493002/diff/9003/32006#newcode92 src/zone-inl.h:92: // TODO(isolates): maybe replace uses of this with placement new so that "placement new" -> "new operator that takes a zone to allocate in". A comment should end with full stop. http://codereview.chromium.org/2493002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
