http://codereview.chromium.org/2582001/diff/1/2 File src/ia32/assembler-ia32.cc (right):
http://codereview.chromium.org/2582001/diff/1/2#newcode2225 src/ia32/assembler-ia32.cc:2225: ASSERT(CpuFeatures::IsEnabled(SSE2)); As far as I can see this is an SSE4 instruction. We must be careful not to use it unless we actually have an SSE4 CPU. http://codereview.chromium.org/2582001/diff/1/2#newcode2248 src/ia32/assembler-ia32.cc:2248: ASSERT(CpuFeatures::IsEnabled(SSE2)); This is an SSE instruction. http://codereview.chromium.org/2582001/diff/1/2#newcode2337 src/ia32/assembler-ia32.cc:2337: Inadvertent edit? http://codereview.chromium.org/2582001/diff/1/4 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2582001/diff/1/4#newcode13505 src/ia32/codegen-ia32.cc:13505: MacroAssembler assembler(buffer, static_cast<int>(actual_size)); Might as well just call this 'masm'? http://codereview.chromium.org/2582001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
