LGTM with comments
http://codereview.chromium.org/2582001/diff/1/4 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/2582001/diff/1/4#newcode13541 src/ia32/codegen-ia32.cc:13541: __ mov(ecx, Operand(esp, stack_offset + kSizeOffset)); I think the clarity of this code would benefit from giving the registers more meaningful names. http://codereview.chromium.org/2582001/diff/1/4#newcode13546 src/ia32/codegen-ia32.cc:13546: __ and_(edx, 0x0F); 0x0F -> 0xF http://codereview.chromium.org/2582001/diff/1/4#newcode13551 src/ia32/codegen-ia32.cc:13551: __ sub(Operand(ecx), edx); Where do the bytes you skipped over here get copied? http://codereview.chromium.org/2582001/diff/1/4#newcode13567 src/ia32/codegen-ia32.cc:13567: __ movdqa(xmm0, Operand(esi, 0x00)); Apart from the dqa/dqu this seems to be duplicated lower down. http://codereview.chromium.org/2582001/diff/1/4#newcode13579 src/ia32/codegen-ia32.cc:13579: // At most 31 bytes to copy. This code seems to be duplicated lower down. http://codereview.chromium.org/2582001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
