LGTM when Anton is happy with the tests. :)
Could you upload a new version for Anton to sign off on? The fixes to
Anton's
comments are not in the currently uploaded version.
http://codereview.chromium.org/2280007/diff/72002/86010
File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/2280007/diff/72002/86010#newcode1321
src/ia32/ic-ia32.cc:1321: // Check that the receiver is a valid JS
object.
Use CmpObjectType for this?
http://codereview.chromium.org/2280007/diff/72002/86021
File src/log.h (right):
http://codereview.chromium.org/2280007/diff/72002/86021#newcode111
src/log.h:111: "KeyedCallDebugPrepareStepIn", \
Strange indentation. I understand why you did it this way but I would
prefer:
V(KEYED_...,
"Keyed...",
"kcdbsi")
http://codereview.chromium.org/2280007/diff/72002/86030
File test/mjsunit/keyed-call-ic.js (right):
http://codereview.chromium.org/2280007/diff/72002/86030#newcode1
test/mjsunit/keyed-call-ic.js:1: // Copyright 2008 the V8 project
authors. All rights reserved.
2010
http://codereview.chromium.org/2280007/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
