Reviewers: Mads Ager, Yury Semikhatsky,
Description:
More precise break points and stepping when debugging
Added support for more precise break points when debugging and stepping. To
achieve that additional nop instructions are inserted where breaking would
otherwise be impossible. The number of nop instructions inserted are
sufficient
to make place for patching with a call to a debug break code stub. On Intel
that
is 5 nop's for 32-bit and 13 for 64-bit. Om ARM 3 nop instructions (12
bytes)
are required.
In order to avoid inserting nop's in to many places a simple ast checker
have
been added to check whether there are breakable code in a statement or
expression. If it is possible to break in an expression no additional break
enabeling code is inserted.
Added break locations to the true and false part of a conditional
expression.
Added stepping tests to cover more constructs.
These changes are only in the full compiler.
Changed the default value for the option --debugger in teh d8 shell from
true to
false. The reason for this is that with --debugger turned on the full
compiler
will be used for all code in when running d8, which can be unexpeceted.
Please review this at http://codereview.chromium.org/2693002/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/assembler-arm-inl.h
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
M src/arm/codegen-arm.h
M src/arm/codegen-arm.cc
M src/arm/debug-arm.cc
M src/arm/full-codegen-arm.cc
M src/assembler.h
M src/assembler.cc
M src/ast.h
M src/builtins.h
M src/builtins.cc
M src/checks.h
M src/codegen.cc
M src/d8.cc
M src/debug.h
M src/debug.cc
M src/flag-definitions.h
M src/full-codegen.h
M src/full-codegen.cc
M src/ia32/assembler-ia32-inl.h
M src/ia32/assembler-ia32.h
M src/ia32/assembler-ia32.cc
M src/ia32/codegen-ia32.h
M src/ia32/debug-ia32.cc
M src/mark-compact.cc
M src/mips/assembler-mips.h
M src/mips/assembler-mips.cc
M src/objects.cc
M src/parser.cc
M src/serialize.cc
M src/x64/assembler-x64-inl.h
M src/x64/assembler-x64.h
M src/x64/assembler-x64.cc
M src/x64/codegen-x64.h
M src/x64/debug-x64.cc
M test/cctest/test-debug.cc
M test/mjsunit/debug-conditional-breakpoints.js
M test/mjsunit/debug-step.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
