Reviewers: William Hesse, Description: Put code flushing behind flag - defaults to false.
Since we have an issue with code flusing on the trybots preventing us from pushing to chromium, a new flag for enabling code flushing, --flush_code, is introduced with this change (defaulting to false). Please review this at http://codereview.chromium.org/2734005/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/flag-definitions.h M src/heap.cc Index: src/flag-definitions.h =================================================================== --- src/flag-definitions.h (revision 4839) +++ src/flag-definitions.h (working copy) @@ -191,6 +191,8 @@ "print more details following each garbage collection") DEFINE_bool(collect_maps, true, "garbage collect maps from which no objects can be reached") +DEFINE_bool(flush_code, false, + "flush code that we expect not to use again before full gc") // v8.cc DEFINE_bool(use_idle_notification, true, Index: src/heap.cc =================================================================== --- src/heap.cc (revision 4839) +++ src/heap.cc (working copy) @@ -605,8 +605,10 @@ EnsureFromSpaceIsCommitted(); if (collector == MARK_COMPACTOR) { - // Flush all potentially unused code. - FlushCode(); + if (FLAG_flush_code) { + // Flush all potentially unused code. + FlushCode(); + } // Perform mark-sweep with optional compaction. MarkCompact(tracer); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
