LGTM
http://codereview.chromium.org/2828004/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2828004/diff/1/2#newcode590 src/arm/codegen-arm.cc:590: void CodeGenerator::LoadGlobalReceiver(Register scratch) { scratch is not used anymore. http://codereview.chromium.org/2828004/diff/1/2#newcode932 src/arm/codegen-arm.cc:932: // On entry the non-constant side of the binary operation is in tos_register_ Doesn't tos contain the result of performing the operation optimisticly? http://codereview.chromium.org/2828004/diff/1/2#newcode949 src/arm/codegen-arm.cc:949: __ sub(r1, tos_register_, Operand(Smi::FromInt(value_))); Why does r0 not need to be loaded with value_? http://codereview.chromium.org/2828004/diff/1/5 File src/arm/virtual-frame-arm.h (right): http://codereview.chromium.org/2828004/diff/1/5#newcode348 src/arm/virtual-frame-arm.h:348: // Flushes all registers, but it puts a copy of the top-of-stack in r0. r0 -> r1 http://codereview.chromium.org/2828004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
