LGTM

http://codereview.chromium.org/2822009/diff/1/2
File include/v8-profiler.h (right):

http://codereview.chromium.org/2822009/diff/1/2#newcode202
include/v8-profiler.h:202: /** Returns edge type (see Type). */
Type -> HeapGraphEdge::Type?

http://codereview.chromium.org/2822009/diff/1/2#newcode244
include/v8-profiler.h:244: JS_OBJECT = 3,  // A JS object (except for
arrays and strings).
JS_OBJECT -> just OBJECT?

http://codereview.chromium.org/2822009/diff/1/2#newcode249
include/v8-profiler.h:249: /** Returns node type (see Type). */
Type -> HeapGraphNode::Type?

http://codereview.chromium.org/2822009/diff/1/2#newcode255
include/v8-profiler.h:255: * string value, or an empty string.
Empty string for code?

http://codereview.chromium.org/2822009/diff/1/2#newcode257
include/v8-profiler.h:257: Handle<String> GetSourceName() const;
GetSourceName() -> GetName()?

http://codereview.chromium.org/2822009/diff/1/2#newcode267
include/v8-profiler.h:267: * that will be reclaimed having this node
deleted.
deleted -> collected.

http://codereview.chromium.org/2822009/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to