http://codereview.chromium.org/2822009/diff/1/2 File include/v8-profiler.h (right):
http://codereview.chromium.org/2822009/diff/1/2#newcode202 include/v8-profiler.h:202: /** Returns edge type (see Type). */ On 2010/06/15 10:48:51, Søren Gjesse wrote:
Type -> HeapGraphEdge::Type?
Done. http://codereview.chromium.org/2822009/diff/1/2#newcode244 include/v8-profiler.h:244: JS_OBJECT = 3, // A JS object (except for arrays and strings). On 2010/06/15 10:48:51, Søren Gjesse wrote:
JS_OBJECT -> just OBJECT?
Done. http://codereview.chromium.org/2822009/diff/1/2#newcode249 include/v8-profiler.h:249: /** Returns node type (see Type). */ On 2010/06/15 10:48:51, Søren Gjesse wrote:
Type -> HeapGraphNode::Type?
Done. http://codereview.chromium.org/2822009/diff/1/2#newcode255 include/v8-profiler.h:255: * string value, or an empty string. On 2010/06/15 10:48:51, Søren Gjesse wrote:
Empty string for code?
Added. Thanks to your comment, I also discovered that I didn't set names for Scripts and SFIs. Fixed. http://codereview.chromium.org/2822009/diff/1/2#newcode257 include/v8-profiler.h:257: Handle<String> GetSourceName() const; On 2010/06/15 10:48:51, Søren Gjesse wrote:
GetSourceName() -> GetName()?
Done. http://codereview.chromium.org/2822009/diff/1/2#newcode267 include/v8-profiler.h:267: * that will be reclaimed having this node deleted. On 2010/06/15 10:48:51, Søren Gjesse wrote:
deleted -> collected.
Done. http://codereview.chromium.org/2822009/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
